ethereum / ethereum/execution-specs

Explore Possibility of Moving `ethereum_test_exceptions` to EELS

Open
#1,422 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
Python
Stars
1.2k
Forks
505
Avg merge
2d 14h
Merged PRs (30d)
116

Description

Currently we have test exception definitions here: https://github.com/ethereum/execution-specs/tree/forks/osaka/src/ethereum_spec_tests/ethereum_test_exceptions.

These are used in tests as means to verify that the state transition failed in the way the test expects it to.

I suggest we move these to the specs part of the repo to:

1) Make them canonical, so the spec definition accounts for all the different ways it can produce an exception.
2) Re-use the same exceptions in the tests and avoid having to parse strings/regex matches.

For this to work, the current definitions in `ethereum_test_exceptions` should subclass `Exception` so we can raise them directly in EELS.

Open to discussion on how this is a good/bad idea!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.