ethereum / ethereum/execution-apis

Fully apply EIP-1898 in specs

Open
#713 2 comments 2 reactions 1 assignee Claimed by @MysticRyuujin View on GitHub
Dominant language
Io
Stars
1.1k
Forks
530
Avg merge
5d 8h
Merged PRs (30d)
9

Description

[EIP-1898](https://eips.ethereum.org/EIPS/eip-1898) is in Final status. It adds the option to use a block hash in several state access methods, where previously a block number was the only option.

The spec mostly has this covered with the `BlockNumberOrTagOrHash` type: https://github.com/ethereum/execution-apis/blob/3547418cc8236968a5f4395d98603c9c9bf0a510/src/schemas/block.yaml#L130

However, the spec is missing the case where the input is a JSON object like `{"blockHash": "0x...", "requireCanonical": true}` is given. We need to add this to the spec and also create tests that verify this with all the methods which are affected.

Unfortunately, we do not have any sidechains in the test chain, i.e. we can't query for non-canonical blocks. Either this part will have to be left untested or we need to updated the test methodology to import a sidechain before importing the canonical one.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.