ethereum / ethereum/eth-hash

`safe-pysha3` using legacy `setup.py` `bdist_wheel` mechanism

Open
#62 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
110
Forks
73
PR merge metrics
No merged PRs in 30d

Description

I installed [`halmos`](https://github.com/a16z/halmos) this morning using the latest `pip` version `25.1` (targeting `main`), and the following warning popped up:

```bash
DEPRECATION: Building 'safe-pysha3' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'safe-pysha3'. Discussion can be found at https://github.com/pypa/pip/issues/6334
```

Looked after into the `halmos` dependencies and found [here](https://github.com/a16z/halmos/blob/2a387c45d7326d38f9475db8f528eb3eadb398df/pyproject.toml#L28):

```toml
"eth_hash[pysha3]>=0.7.0",
```

From quickly checking, it looks like [`pysha3`](https://github.com/5afe/pysha3) is not really actively maintained anymore. For now nothing breaks, but wanted to raise this issue to have a plan going forward.

Contributor guide

Open the contributing guide

Research direction

Start with pyproject.toml at the referenced dependency entry for "eth_hash[pysha3]>=0.7.0", then inspect the pysha3 project and the pip deprecation warning. Determine a supported dependency or build path and verify that installing halmos no longer triggers the legacy setup.py bdist_wheel warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.