ethereum / ethereum/consensus-specs

should proposer boost be counted in `is_parent_strong`?

Open
#4,899 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4k
Forks
1.3k
Avg merge
1d 7h
Merged PRs (30d)
58

Description

In Gloas we change `is_parent_strong` to only count the attestation score and no longer proposer boost. In previous forks we use `get_weight` which also counts proposer boost for it.

Most of the applications for `is_parent_strong` are done at the beginning of the slot when the proposer is about to choose head to propose, so anyway there won't be a proposer boost root set, but `should_override_forkchoice_update` may cause trouble cause implementers may count attestations early without running new_slot and without unsetting proposer boost root, this would lead to different behaviors pre and post-gloas.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.