ethereum / ethereum/consensus-specs

Duplicate collected test cases in the generator

Open
#4,705 0 comments 0 reactions 1 assignee Claimed by @leolara View on GitHub
Dominant language
Python
Stars
4k
Forks
1.3k
Avg merge
1d 7h
Merged PRs (30d)
58

Description

For some reason, there are a bunch of duplicate test cases (same identifier) which are being executed/generated.

I added some checks to the generator and there are ~90k duplicate tests.

```
Total test cases: 199853
Unique identifiers: 111385
```

This bug showed itself in the nightly reference test generator:

![Image](https://github.com/user-attachments/assets/0abbfd4f-3ede-4620-b304-d514b049a094)

It seems that two instances of a test with the same identifier were being executed at the same time. The first one finished & left the second one in the queue forever, eventually timing out.

When debugging this, I noticed that this test showed up in the logs multiple times:

Image

Image

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.