ethereum / ethereum/async-service

run_asyncio_service must guarantee that the service has finished before returning

Open
#65 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
10
Forks
11
PR merge metrics
No merged PRs in 30d

Description

We need to either get rid of `run_asyncio_service()` or fix it so that it cancels the manager and awaits for it to be finished when manager.run() returns

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the run_asyncio_service entry point and tracing how manager.run() returns. Review the service lifecycle and existing async tests, if present, to determine how completion is observed. Done means the manager has been cancelled and awaited before run_asyncio_service returns, or the entry point is removed as the issue discusses.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.