ethereum-optimism / ethereum-optimism/specs

[OP Plasma] Specify commitment encoding standards for generic server types

Open
#229 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
178
Forks
205
Avg merge
5d 2h
Merged PRs (30d)
6

Description

Alt da servers (I.e, generic commitment types) are expected to encode the type byte prefix as per the server side generated commitment for the client to decode when querying. Additionally these servers are expected to decode the type byte when reading (i.e, /GET).

The spec should likely be updated to reflect this server side encoding/decoding requirement. Otherwise it may make sense to only do the type encoding within core OP services. Currently the commitment is decoded in the da client to then be re-encoded when setting the tx data byte resulting in a redundant encoding operation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked locations in op-plasma/daclient.go (lines 133-136) and op-batcher/batcher/driver.go (lines 505-513) to trace the current commitment encoding flow. Then review the OP Plasma specification and decide whether generic servers or only core OP services own type-byte encoding and decoding. Done means the chosen behavior and server requirements are specified clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design, documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.