ethereum-optimism / ethereum-optimism/optimism

op-acceptance-tests: remove TestConductorLeadershipTransfer kona-node skip

Open
#22,262 0 comments 0 reactions 1 assignee Claimed by @joshklop View on GitHub
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 38m
Merged PRs (30d)
164

Description

## Summary

[`TestConductorLeadershipTransfer`](https://github.com/ethereum-optimism/optimism/blob/develop/op-acceptance-tests/tests/base/conductor/leadership_transfer_test.go) is skipped when the acceptance suite runs against kona-node.

The conductor preset assumes its CL is `*sysgo.OpNode` and panics when the selected CL is `*sysgo.KonaNode`.

## Required work

Generalize the conductor preset around backend-neutral CL capabilities, provide the Kona implementation, and remove the Kona skip from the leadership-transfer test.

## Acceptance criteria

- [ ] The root cause and resolution are documented.
- [ ] `TestConductorLeadershipTransfer` no longer skips when `DEVSTACK_L2CL_KIND=kona-node`.
- [ ] The same leadership-transfer behavior is exercised against real kona-node and op-node sequencers.
- [ ] Existing op-node coverage continues to pass.

## Related

- https://github.com/ethereum-optimism/optimism/issues/21903
- https://github.com/ethereum-optimism/optimism/issues/21906
- Parent inventory: https://github.com/ethereum-optimism/protocol-team/issues/101

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.