ethereum-optimism / ethereum-optimism/optimism

[SuperZKDG] Scripts checks and naming

Open
#20,841 0 comments 0 reactions 0 assignees View on GitHub
M-needs-triage
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 15h
Merged PRs (30d)
145

Description

## Scope

Minor script touch-ups and ABI alignment checks for the super-root ZKDG, beyond the contract and OPCM changes covered in milestones 2 and 3.

---

## Workstreams

### Deployment script alignment
Update the contract name string in `deployZKDisputeGameImpl()` and the `vm.label` call in `DeployImplementations.s.sol` if the contract gets renamed (e.g. `ZKDisputeGame.sol` → `SuperZKDisputeGame.sol`). Skip if the name stays.

### ABI alignment check
Spot-check that the Solidity `OPContractsManagerV2.UpgradeInput` ABI still matches the Go-side `embedded.upgradeInputEncoder` after the OPCM changes (variable-length `gameArgs`). Update the encoder or the hardcoded hex in the integration test (`TestEndToEndBootstrapApplyWithUpgrade`) if the shape shifts.

---

## Definition of Done

- [ ] Scripts updated if the contract is renamed (or confirmed no rename is happening)
- [ ] ABI alignment confirmed end-to-end (Solidity ↔ Go encoder ↔ integration test hex)

---

## Weekly Updates

**[YYYY-MM-DD]** _latest update_

Contributor guide

Open the contributing guide

Research direction

Start in DeployImplementations.s.sol at deployZKDisputeGameImpl() and the vm.label call, checking whether the contract rename occurred. Then compare Solidity’s OPContractsManagerV2.UpgradeInput with embedded.upgradeInputEncoder and run TestEndToEndBootstrapApplyWithUpgrade; done means the scripts and Solidity-to-Go ABI encoding agree, including variable-length gameArgs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, solidity
Domain
blockchain, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.