ethereum-optimism / ethereum-optimism/optimism

fix(contracts-bedrock): SystemConfig base fee require message contradicts <= check

Open
#19,868 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 18h
Merged PRs (30d)
134

Description

## Problem

`_setResourceConfig` requires `minimumBaseFee <= maximumBaseFee`, but the revert string says the minimum must be **less than** the maximum, which is wrong when the two are equal.

## Expected

Message should say **less than or equal to** max base fee.

## PR

Tracked in the linked pull request.

Contributor guide

Open the contributing guide

Research direction

Start by locating _setResourceConfig in the contracts-bedrock sources and inspect the revert string for the minimumBaseFee <= maximumBaseFee check. Done means the message accurately says that the minimum base fee may be less than or equal to the maximum base fee.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.