ethereum-optimism / ethereum-optimism/optimism

fix(op-node/p2p): gossip publisher does not close blocksV3/blocksV4 on shutdown

Open Beginner friendly
#19,860 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 18h
Merged PRs (30d)
134

Description

## Problem

The `publisher` type holds four block gossip topics (`blocksV1`–`blocksV4`), but `Close()` only shut down V1 and V2. V3/V4 resources may leak on node shutdown.

## Expected

`Close()` should close all four topics and join any returned errors (same pattern as V1/V2).

## PR

Will be addressed by the linked pull request.

Contributor guide

Open the contributing guide

Research direction

Start at the op-node/p2p publisher type and its Close() method, then compare the existing blocksV1/blocksV2 shutdown and error-joining pattern. Done means blocksV3 and blocksV4 are also closed and any returned errors are joined consistently with V1/V2.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.