ethereum-optimism / ethereum-optimism/optimism
Remove deprecated OPCMv1 fields in ReadSuperchainDeployment script
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 134
Description
### Overview
Clean up deprecated fields that were used for OPCMv1 compatibility. These fields are no longer needed once OPCMv1 is fully deprecated.
### Fields to Remove
`OPCMAddress` field:
- `op-deployer/pkg/deployer/opcm/read_superchain_deployment.go` - Remove `OPCMAddress common.Address` field from struct.
- `op-deployer/pkg/deployer/pipeline/init.go` - Remove `OPCMAddress` handling.
- `packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol` - Remove `IOPContractsManager opcmAddress` field.
`ProtocolVersions` fields:
- `op-deployer/pkg/deployer/opcm/read_superchain_deployment.go` - Remove `ProtocolVersions` fields.
- `op-deployer/pkg/deployer/pipeline/init.go` - Remove `ProtocolVersions` handling.
- `op-deployer/pkg/deployer/pipeline/init_test.go` - Remove `ProtocolVersions` test cases.
- `packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol` - Remove `ProtocolVersions` fields.
Contributor guide
Research direction
Start with op-deployer/pkg/deployer/opcm/read_superchain_deployment.go and op-deployer/pkg/deployer/pipeline/init.go, then inspect the matching fields in packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol. Remove the deprecated OPCMAddress and ProtocolVersions handling, update the listed init_test.go cases, and run the relevant pipeline tests to confirm the cleanup is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, solidity
- Domain
- backend, blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100