ethereum-optimism / ethereum-optimism/optimism

Validate extradata pre-Holocene in engine_consolidate

Open
#17,337 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 15h
Merged PRs (30d)
145

Description

I ended up reverting this [b54581d](https://github.com/ethereum-optimism/optimism/pull/17307/commits/b54581dfa78ce5d9b347730030e054425fe3eb43), I didn't want to change the existing behaviour (it broke existing tests). Happy to look again in a followup PR>

_Originally posted by @geoknee in https://github.com/ethereum-optimism/optimism/pull/17307#discussion_r2324994070_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the reverted commit b54581d from pull request 17307 and locate the engine_consolidate implementation and the existing tests it changed. Compare the pre-Holocene extradata validation behavior with those tests; done means the intended validation is covered without breaking the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.