ethereum-optimism / ethereum-optimism/optimism
op-node/rollup/engine:`EngineResetConfirmedEvent` emitted before reset is actually confirmed
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 145
Description
https://github.com/ethereum-optimism/optimism/blob/cbc78c976f3da867f3758012325c60a2d9edd038/op-node/rollup/engine/events.go#L439-L453
I also think that this code is actually problematic. The above code just emits `TryUpdateEngineEvent` and then immediately emits `EngineResetConfirmedEvent` even though the FCU call may fail. So we may update the status even though the engine is somewhere completely else. We should probably fix this to only emit `EngineResetConfirmedEvent` when the FCU call really confirmed to have been executed properly. But not within the scope of this PR of course.
_Originally posted by @sebastianst in https://github.com/ethereum-optimism/optimism/pull/16296#discussion_r2135820632_
Contributor guide
Research direction
Start in op-node/rollup/engine/events.go at lines 439-453 and trace the TryUpdateEngineEvent handling and FCU call result. Confirm the reset event is emitted only after the FCU call is successfully confirmed, and verify that failed calls do not update the reset status.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100