ethereum-optimism / ethereum-optimism/optimism

setSuperFaultGameImplementation() -> DeploySuperFaultGame2.run()

Open
#15,544 0 comments 0 reactions 1 assignee Claimed by @AmadiMichael View on GitHub
T-evm-safety T-smart-contract
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 38m
Merged PRs (30d)
164

Description

In order to ensure that the contracts deployed in our test suite are the same as those deployed by op-deployer we should simplify `Deploy.s.sol` by removing any custom deployment logic that re-implements functionality that exists in the [deployment scripts](https://github.com/ethereum-optimism/optimism/tree/develop/packages/contracts-bedrock/scripts/deploy) used by `op-deployer`.

Specifically, `setSuperFaultGameImplementation()` should be removed, and replaced by calls to a new DeploySuperFaultGame2.s.sol script i.e via a `DeploySuperFaultGame2.run()` call.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.