ethereum-optimism / ethereum-optimism/optimism

op-e2e: fix ActiveSequencerCheckDuration

Open
#15,046 0 comments 0 reactions 0 assignees View on GitHub
A-op-batcher A-op-proposer
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 15h
Merged PRs (30d)
145

Description

When `ActiveSequencerCheckDuration` was introduced it was left set to 0 in programmatic configs, and it seems like this causes instant checking / hot-loops in op-e2e.
The `Check()` method should also ensure it's non-zero, so it cannot have the wrong value anymore.

This applies to both the batcher, proposer, and potentially other services.

Contributor guide

Open the contributing guide

Research direction

Start by locating the programmatic configurations and Check() methods for ActiveSequencerCheckDuration in the op-e2e batcher and proposer, then inspect whether other services use the same setting. Run the relevant op-e2e checks or tests; done means the duration cannot remain zero and the services no longer enter instant-checking hot-loops.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.