ethereum-optimism / ethereum-optimism/optimism

op-deployer: `--proof-maturity-delay-seconds` is ignored for custom intent

Open
#14,869 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 38m
Merged PRs (30d)
164

Description

**Bug Description**
`op-deployer bootstrap implementations --proof-maturity-delay-seconds` is not reflected in the `state.json`, because the [`deploy-implementations` pipeline](
https://github.com/ethereum-optimism/optimism/tree/d509f44f487b35e67bf6e0050ebc0ee06ac8b944/op-deployer/pkg/deployer/apply.go#L307) of the `op-deployer apply` step (which can't be skipped) creates an `OptimismPortal2` implementation [with standard delays](
https://github.com/ethereum-optimism/optimism/tree/d509f44f487b35e67bf6e0050ebc0ee06ac8b944/op-deployer/pkg/deployer/pipeline/implementations.go#L37) -- and it's this implementation that ultimately ends up in `state.json`.

The same also happens with `--dispute-game-finality-delay-seconds`.

**Steps to Reproduce**

```console
$ head -n1 deploy/sepolia/intent.toml
configType = 'custom'

$ op-deployer bootstrap implementations \
--proof-maturity-delay-seconds 36 \
--dispute-game-finality-delay-seconds 60 \
--outfile deploy/sepolia/implementations.json
# ...

$ cast call $(jq -r .OptimismPortalImpl deploy/sepolia/implementations.json) 'proofMaturityDelaySeconds()' | cast to-dec
36

$ cast call $(jq -r .implementationsDeployment.optimismPortalImplAddress deploy/sepolia/state.json) 'proofMaturityDelaySeconds()' | cast to-dec
604800
```

**Expected behavior**

* `optimismPortalProxyAddress` in `state.json would point to the Optimism Portal instance created by the `bootstrap implementations` step, with the correct delays set.

**Environment Information:**
op-deployer @ f2d662612014c125b2e9477052ff44184a640074

**Configurations:**

**Logs:**

**Additional context**

---

⚠️ **Notice:** Issues that do not include the following sections will be subject to closure:
- Bug Description
- Steps to Reproduce
- Environment Information

Please ensure all required sections are filled out accurately to expedite the debugging process and improve issue resolution efficiency.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.