ethereum-optimism / ethereum-optimism/optimism

dedupe forge artifact structs

Open
#14,826 0 comments 0 reactions 0 assignees View on GitHub
A-op-chain-ops
Dominant language
Go
Stars
6.5k
Forks
4k
Avg merge
2d 15h
Merged PRs (30d)
145

Description

There are a bunch of redundant structs/types in op-chain-ops/foundry and op-chain-ops/solc (e.g. [Artifact](https://github.com/ethereum-optimism/optimism/blob/develop/op-chain-ops/foundry/artifact.go#L20-L27) and [ForgeArtifact](https://github.com/ethereum-optimism/optimism/blob/develop/op-chain-ops/solc/types.go#L267-L277)).

These can be deduped. The `solc` ones are more accurate and in-depth, so they should remain and the `foundry` ones should be removed

Contributor guide

Open the contributing guide

Research direction

Start by comparing op-chain-ops/foundry/artifact.go and op-chain-ops/solc/types.go, especially Artifact and ForgeArtifact, then search the repository for uses of the foundry types. Done means the redundant foundry artifact structs are no longer needed, affected references use the solc definitions, and the affected Go packages still build and test successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.