ethereum-optimism / ethereum-optimism/optimism
Deprecate deploy-config (OPCM - upgrades)
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 145
Description
The test scripts (ie. Deploy.s.sol) still depend on test values coming from `hardhat.json`, by way of `DeployConfig.s.sol`.
This monolithic approach to config has been deprecated in favor of using `op-deployer` which consumes an `intent.toml` file ([example](https://github.com/ethereum-optimism/devnets/pull/34/files#diff-ffdd0d4ec399fb055a0a8d3eb731dcffcf272cec33691f93f1ba14dfe77931ed)). We should replace `hardhat.json` with such an intent file.
This work is closely related to #13331.
Contributor guide
Research direction
Start with Deploy.s.sol and DeployConfig.s.sol to trace how test values come from hardhat.json, then compare the intent.toml example consumed by op-deployer. The work is done when the test scripts no longer depend on hardhat.json and use the intent-file approach; review related issue #13331 for context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain, devops
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100