ethereum-optimism / ethereum-optimism/optimism
Comment says 4 bytes, but it is actually the word size
Open
A-pkg-contracts-bedrock
C-good first issue
MT cannon - audit findings
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 4k
- Avg merge
- 2d 38m
- Merged PRs (30d)
- 164
Description
As per spearbit audit finding, we have the following finding:
**Description**
Comment says 4 bytes, but it is actually the word size. Also, the comment is bellow the aligning operation.
**Recommendation**
Move the comment above the aligning, and use "word size" instead of "4 bytes".
[packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol](https://cantina.xyz/code/4ea41142-4359-4f62-bfaa-a542172cab5d/packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol#L260)
// mask the addr to align it to 4 bytes
Contributor guide
Assessment
This issue has not been assessed yet.