ethereum-optimism / ethereum-optimism/optimism
op-service/testlog: pull in upstream geth features / improvements
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 134
Description
The `op-service/testlog` package was forked off from the geth `testlog` package, since `testlog` is "internal", and cannot be relied on as dependency.
At the same time, the `testlog` in the monorepo has some opinionated improvements, like padding/alignment of filenames that are prefixed by the underlying test-logger.
Upstream, there are some buffer / locking related improvements, which we can merge back in.
Since the original fork, the `slog` package also became a thing in Go, and some features/flexibility of that may be nice to integrate also, if not already done in Geth.
Contributor guide
Research direction
Start by inspecting the op-service/testlog package and comparing it with upstream Geth's testlog implementation. Review the upstream buffer and locking changes, then assess whether relevant slog features are already present. Done means the selected compatible improvements are integrated without losing the package's existing formatting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100