ethereum-lists / ethereum-lists/wallets

Initial data / structure

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
12
Forks
7
PR merge metrics
No merged PRs in 30d

Description

we could take initial data from:
https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-data.ts
and about EIP-6963 support from here:
https://github.com/WalletConnect/EIP6963/blob/master/src/utils/constants.ts
Another source: https://github.com/fluidkey/walletbeat/blob/main/src/data/data.ts

Unfortunately both do not really separate the data from code.

Data-Format wise I think we can collapse the gazillion fields of the ethereum-org data by introducing arrays for supported platforms, standards, features and socials.
I am struggling a bit with how to deal with variants currently. E.g. if a wallet exists for desktop and mobile - they will have different support status for e.g. EIP-6963. I am leaning as then seeing them as completely different wallets instead of having conditional properties - but this will lead to some duplication. So maybe we should have a way to have "base properties" that can be delegated to. So we have e.g. 2 wallets "MetaMask mobile" and "MetaMask desktop" and both delegate to some "MetaMask base"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.