ethereum-lists / ethereum-lists/chains

Field "chain" is used twice with different meaning/definition

Open
#2,373 7 comments 5 reactions 0 assignees View on GitHub
enhancement
Dominant language
Kotlin
Stars
9.8k
Forks
8.1k
Avg merge
1d 6h
Merged PRs (30d)
83

Description

I would clarify what does "chain" mean, given that we have "parent.chain" that has a different definition.
Since the latter is dependent on / specific to this repository and doesn't have a correspondence on a on-chain value (EIPs are off-chain right?), I would consolidate to the former and make a clear definition of what is it.
There are irregularities currently on the "chain" field values, examples:

- Capitalized/UPPERCASE/lowercase (ETH/ETH vs Evmos/evmos)
- equal to the symbol of the native currency vs. to the name or shortname of the chain (ETH vs Solana vs evmos)
- is it a unique representation of the parent chain or parent native currency (by slip44 maybe?)? Seems so with children of Ethereum but not otherwise, like Aurora-NEAR, Avalanche-AVAX, etc..

In general, I would add comments to
https://github.com/ethereum-lists/chains/blob/master/model/src/main/kotlin/org/ethereum/lists/chains/model/Chain.kt
to help listers provide consistent values.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.