eth-p / eth-p/bat-extras

feature request: batgrep support for ripgrep's --hyperlink-format

Open
#129 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
1.6k
Forks
95
PR merge metrics
No merged PRs in 30d

Description

I made an attempt:

```diff
diff --git a/src/batgrep.sh b/src/batgrep.sh
index 1f02138..e521abe 100755
--- a/src/batgrep.sh
+++ b/src/batgrep.sh
@@ -247,6 +247,11 @@ while shiftopt; do
RG_ARGS+=("$OPT" "$OPT_VAL")
;;

+ --hyperlink-format*)
+ RG_ARGS+=("$OPT=$OPT_VAL")
+ ;;
+
# bat options

# Script options
```

But the hyperlinks don't come through like I was hoping, and I got pretty stumped trying to figure out why.

clicking on a hyperlink to open the file at the spot where the match is is one of my favorite features of ripgrep, and I'd love to use it with batgrep.

Contributor guide

Open the contributing guide

Research direction

Start in src/batgrep.sh, especially the option-parsing loop and the existing --hyperlink-format case. Reproduce the reported behavior with batgrep and ripgrep, then trace why the hyperlinks are not preserved. Done means ripgrep’s hyperlinks open the matching file at the match location when using batgrep.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.