etclabscore / etclabscore/pristine-typescript

semantic-release should not commit to master

Open
#21 0 comments 0 reactions 0 assignees View on GitHub
triage
Dominant language
JavaScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
At the moment, when semantic release is doing the publish step, it includes the changelog.

However, it also commits the changelog, and pushes this commit to master. Since master should be a protected branch, this presents some challenges that force us to loosen the rules, and to put powerful tokens in sketchy places.

**Describe the solution you'd like**
semantic-release should do everything on a `release` branch, opening a PR with the results instead of pushing them directly to master. This PR should be ignored by CI.

**Describe alternatives you've considered**
I've tried nothing and I'm all out of ideas.

**Additional context**
Perfection is the goal here ladies & non ladies.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.