espruino / espruino/BangleApps

[android/messages] Message Tick/Cross button implementation

Open
#2,489 5 comments 2 reactions 0 assignees View on GitHub
area-gadgetbridge state-decision-needed type-enhancement
Dominant language
JavaScript
Stars
571
Forks
1.3k
Avg merge
17h 38m
Merged PRs (30d)
17

Description

### Affected hardware version

Bangle 2

### Your firmware version

2v16

### The bug

When a message comes in on Android, you often have two buttons, Tick/Cross.

On iPhone, these are positive and negative responses to a message if available (according to Apple).

Currently,

Tick -> 'OPEN' in Gadgetbridge
Cross -> 'DISMISS' in Gadgetbridge

These are from `GBDeviceEventNotificationControl.Event` which can have the following types:

```
DISMISS,
DISMISS_ALL,
OPEN,
MUTE,
REPLY,
```

Right now, as far as I can tell, OPEN will open the notification in Android, and DISMISS actually removes it from the device

So what should the two buttons actually do? 'OPEN' doesn't seem useful since the device is in your pocket.

Should Tick call DISMISS, and Cross just mark the message read on Bangle.js and do nothing else? Or do we just have a single button that calls DISMISS, and 'back' marks read anyway?

... and when we get this figured out, we'll probably just get rid of the buttons and move to a swipe in either direction - giving more screen real estate for the text

### Installed apps

android,messages

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.