espruino / espruino/BangleApps

[weather] Clkinfo `conditionWithTemperature` item not showing the range

Open
#2,392 3 comments 1 reaction 0 assignees View on GitHub
area-clocks state-started type-enhancement
Dominant language
JavaScript
Stars
571
Forks
1.3k
Avg merge
17h 38m
Merged PRs (30d)
17

Description

### Affected hardware version

Bangle 2

### Your firmware version

2v16

### The bug

Since the last update to the weather clkinfo (0.22), a new item in the weather `conditionWithTemperature` has been created, now this item cannot be viewed as ranged item in clocks like circleclock as it is missing the proper setting (`hasRange`).
The solution is trivial, however I'd like to ask a more broad question about this specific item, I suppose the item was created to represent the weather circle in clkinfo (and export the feature to other clocks), the idea is good but the nice stuff about that circle was the ability to show multiple data in the circle (e.g. the range could be set to humidity as the temperature is already available as text).
To do the same with this item we could:
* Create a lot of items like `conditionWithXYZ` for all useful combinations of texts and ranges (just kidding, this is clearly not ideal)
* Have a setting somewhere for this (requires a few changes in the clkinfo module but I have the feeling this is what will happen sooner or later)
* Change this specific item to show the humidity in the range (forgetting about wind, which was the other option in circlesclock, temperature wasn't available in that gauge) and maybe call it `conditionWithData`, waiting for a possibility to set it up

Now, the 3rd option was my usecase (purely personal preference, but quick and easy fix). While adding the `hasRange` field, I would also modify that, to add more details to the clkinfo.
Again, that boils down to personal preference, so I would wait for some opinion before changing that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.