esp8266 / esp8266/Arduino

OTA Web server documentation is invalid

Open
#7,592 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
16.7k
Forks
13.1k
PR merge metrics
No merged PRs in 30d

Description

As you can see [there](https://arduino-esp8266.readthedocs.io/en/latest/ota_updates/readme.html#http-server) on the OTA web server example there is code like this
```cpp
ESPhttpUpdate.update("192.168.0.2", 80, "/arduino.bin");
```
or this
```cpp
t_httpUpdate_return ret = ESPhttpUpdate.update("192.168.0.2", 80, "/esp/update/arduino.php", "optional current version string here");
```
which is invalid, as you can see on ESP8266httpUpdate.cpp at line 152
```cpp
HTTPUpdateResult ESP8266HTTPUpdate::update(const String& host, uint16_t port, const String& uri,
const String& currentVersion)
{
HTTPClient http;
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
http.begin(host, port, uri);
#pragma GCC diagnostic pop
return handleUpdate(http, currentVersion, false);
}
```
it says that's deprecated, could you please update the documentation?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.