Enhance FLASH size detection (was HTTP update fails on custom hardware)
- Dominant language
- C++
- Stars
- 16.7k
- Forks
- 13.1k
- PR merge metrics
- No merged PRs in 30d
Description
#### Hardware
Hardware: Custom (ESP8266 + AT25SF321)
Core Version: 2.3.0
### Description
I work on a custom hardware (ESP8266 + AT25SF321). Everything works fine excepting the OTA HTTP update.
The problem comes from the core function `EspClass::getFlashChipRealSize`. What is the exact purpose of this piece of code? It heavily relies on the flash chip id but, of course, our flash chip doesn't comply to the implicit rule used to determine the chip size without asking to it directly.
I corrected the error simply by replacing the method content by a call to the reliable `EspClass::getFlashChipSize`.
Why is there two different implementations for the same purpose?
By searching for the `EspClass::getFlashChipRealSize` usage, I found out that it seems to be used only by the updater.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.