esnet / esnet/react-timeseries-charts

EventMarker Flag Not Visible Outside ClipPath

Open
#436 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
876
Forks
279
PR merge metrics
No merged PRs in 30d

Description

When using an EventMarker of type "flag" in combination with a EventChart, the actual flag popup will not appear. This is because it is by default outside of the clipPath generated for the EventChart area. This is especially true if the EventMarker flag is styled to appear above or below the Event data line.

What if we made that clipPath in the ChartRow component optional via a prop? At least for an EventChart, the Event bar would only show with slightly more height, and the flag popup would appear on hover.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.