esnet / esnet/react-timeseries-charts

ValueList ignores its style property and uses hard-coded colors anyway

Open
#430 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
876
Forks
279
PR merge metrics
No merged PRs in 30d

Description

# 🐛Bug report

ValueList ignores the style parameters provided by its parent component (LabelAxis).

I'm setting the property "style" in LabelAxis to this, as specified in the LabelAxis docs:

```
style={{
axis: {
fill: 'black',
stroke: 'black',
background: 'black',
color: 'black',
opacity: '0.0',
},
label: {
fontSize: 12,
fill: 'black',
stroke: 'black',
background: 'black',
color: 'black',
opacity: '0.0',
},
values: {
fill: 'black',
stroke: 'black',
background: 'black',
color: 'black',
opacity: '0.0',
}
}}

```

The style.values object is making it into ValueList as prop "style":

```
style={{
fill: 'black',
stroke: 'black',
background: 'black',
color: 'black',
opacity: '0.0',
}}
```

And then ValueList just ignores it and applies its default styles and colors.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.