esnet / esnet/react-timeseries-charts

No way to style legend

Open
#365 2 comments 0 reactions 0 assignees View on GitHub
:sparkles: enhancement
Dominant language
JavaScript
Stars
876
Forks
279
PR merge metrics
No merged PRs in 30d

Description

The "styler" object in this library actually hard-codes the colors of legend labels to 333 and values to 999 and prevents you from changing them. This basically prevents you from using a legend on a chart with a dark background.

There's no reason why the colors of legend labels and values shouldn't be configurable. There aren't any other hard-coded colors being set in styler.js, just these two.

Contributor guide

Open the contributing guide

Research direction

Start by inspecting styler.js, especially the legend label and value color handling described in the issue. Trace how the styler is used by the chart legend and check existing styling configuration patterns. Done means those two colors are configurable instead of fixed, with dark-background legends able to use alternate values.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
data-visualization, frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.