esnet / esnet/react-timeseries-charts

minBarHeight and zero'd values don't render

Open
#364 0 comments 0 reactions 0 assignees View on GitHub
:question: question
Dominant language
JavaScript
Stars
876
Forks
279
PR merge metrics
No merged PRs in 30d

Description

# ❔Question

Using the `BarChart`, I have`minBarHeight` set to 0 and data points that looks like this:

```
["2015-12-1", 80, 38, 44, 100, "id"],
["2015-12-2", 17, 20, 29, 100, "id"],
["2015-12-3", 2, 67, 60, 100, "id"],
["2015-12-4", 73, 77, 79, 100, "id"],
["2015-12-5", 0, 0, 0, 100, "id"],
["2015-12-6", 58, 57, 78, 100, "id"],
["2015-12-7", 72, 59, 52, 100, "id"],
["2015-12-8", 12, 34, 9, 100, "id"],
["2015-12-9", 82, 36, 58, 100, "id"]
```

For `2015-12-5` You'll notice that 3 of the columns are 0 and one is 100. In this case, nothing renders for that day. Should it be expected that the one data point that's 100 would render, whereas the others simply would not?

Thank you!

Contributor guide

Open the contributing guide

Research direction

Start at the BarChart component and trace how minBarHeight and zero-valued data points are handled for the supplied time-series data. Confirm whether the 100-valued column renders on 2015-12-5 while the zero-valued columns do not, then determine the expected behavior from the component's existing rendering logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.