esnet / esnet/pond

Timeseries with names containing dots are not compatible with fieldSpecs

Open
#141 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
211
Forks
42
PR merge metrics
No merged PRs in 30d

Description

Hi,
I would like to use react-timeseries-charts/pond on my project (a monitoring infrastructure for a cloud provider) but I stumble on a kind of "dumb" problem related to field specs.

The metrics in this system are all organized using a naming scheme which uses dots. In this case, the dots do not have any relationship to a hierarchy of maps, they are just a way to name the metrics in a logical way. For instance, we have:

- os.disk.inodes.count
- os.disk.space.free
- os.disk.space.min
- os.multiprocess.runs.zookeeper.status
- os.process.runs.nimbus.status
- os.process.runs.redis.status
- os.process.runs.storm.status

...

As you can see, this naming scheme prevents me from using pond, because pond interprets all the dots in metric names as field separators.

My question is: would you be willing to accept a patch to pond in which the user could specify the field separator used for field specs in the get() method of an event. '.' would remain the defaut (thus having no impact on existing code), but one could specify something else ('/' for instance in my case). I would then propose changes to react-timeseries-chart to add extra 'fieldSeparator' property to the various charts (again, with '.' default so that there is no impact on existing code) so one could specify the field separator for a given chart.

Regards

Lukas

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.