esnet / esnet/pond

Align with limit of zero doesn't set to null

Open
#113 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
211
Forks
42
PR merge metrics
No merged PRs in 30d

Description

https://github.com/esnet/pond/blob/master/packages/pond/src/align.ts#L97

Because it checks if there IS a limit first, this if statement never gets entered if limit is zero, so it doesn't get set to null.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.