esnet / esnet/iperf

reserved identifier violation

Open
#805 1 comment 0 reactions 0 assignees View on GitHub
bug portability
Dominant language
C
Stars
8.8k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

I would like to point out that identifiers like “[`__IPERF_API_H`](https://github.com/esnet/iperf/blob/d13fa7ce39a30cb67f5660a9c1aeabc99af601ae/src/iperf_api.h#L27 "Update candidate")” and “[`__NET_H`](https://github.com/esnet/iperf/blob/34f878a2c0efb19129a72591905c11a80044fabb/src/net.h#L27 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.