esbenp / esbenp/jquery-oauth

Refreshing flag not released after failed tokenExpiration

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
53
Forks
17
PR merge metrics
No merged PRs in 30d

Description

If it happens that processing of tokenExpiration event fails (e.g. server denied to re-new the access token and manual login is necessary again) the 'refreshing' flag remains set, what prevents from raising next 'tokenExpiration' events (even after next successful login).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the tokenExpiration event handling and the code that sets the 'refreshing' flag. Reproduce a failed token renewal followed by a successful login, then verify that a later tokenExpiration event can be processed instead of being blocked by the stale flag.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.