esamattis / esamattis/underscore.string

`_.reverse` is buggy

Open
#220 2 comments 0 reactions 0 assignees View on GitHub
candidate
Dominant language
JavaScript
Stars
3.4k
Forks
367
PR merge metrics
No merged PRs in 30d

Description

For example:

``` js
// To see which symbols are being used here, check:
// http://mothereff.in/js-escapes#1ma%C3%B1ana%20man%CC%83ana
naiveReverse('mañana mañana');
// → 'anãnam anañam'
// Wait, so now the tilde is applied to the `a` instead of the `n`? WAT.
```

Another issue is explained here: http://stackoverflow.com/a/16776380/96656 (Posting a link because GitHub won’t let me use the symbols in a comment.)

You could use [Esrever](http://mths.be/esrever) for this. Something like:

``` js
_.reverse = require('esrever').reverse;
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.