esamattis / esamattis/underscore.string

splice conflict

Open
#149 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.4k
Forks
367
PR merge metrics
No merged PRs in 30d

Description

Hello there

I just noticed the following problem

``` javascript
/* without underscore.string */
_([1, 2, 3]).splice(0, 1) // returns [2, 3]

/* with underscore.string */
_([1, 2, 3]).splice(0, 1) // returns ",2,3"
```

could the splice method be renamed so it does not conflict with Array.splice ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.