erikras / erikras/react-redux-universal-hot-example

Server return status 200 while rendering 404 page

Open
#990 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.1k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

Because of the [catch-all route](https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/routes.js#L55) `match` will always match a route and `renderProps` will always be defined. For this reason, [this branch is never reached](https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/server.js#L105-L107) and the 404 page is [served with a status code of 200](https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/server.js#L98).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.