erikras / erikras/react-redux-universal-hot-example

Best practice for including images?

Open
#903 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.1k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

There's two ways to include images:
1) Include it in /static and reference it directly
2) Include it in the component and use require (which embeds it as a data:uri).

In the former, I'd get the benefit of caching, but on the other hand, if I replace a file, it seems like it would still be cached by the browser (can't see that webpack is doing the type of renaming with has that grunt does)

In the latter, I won't get stale files but the data:uri will bloat my response (especially if an image is repeated) and I won't get any benefit of caching.

Advice?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.