erikras / erikras/react-redux-universal-hot-example

Should forms be separated into a container and a dumb component?

Open
#376 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.1k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

I'd propose that https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/components/SurveyForm/SurveyForm.js should be split into a container and a dumb form component. The container would connect to the redux-form store and contain the validation and submit functionality. It should only pass its props to the dumb form component. @erikras are you on board with a change like this? If so I could send a PR for that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.