erikras / erikras/react-redux-universal-hot-example
[question] Should Html use @connect?
Open
- Dominant language
- JavaScript
- Stars
- 12.1k
- Forks
- 2.5k
- PR merge metrics
- No merged PRs in 30d
Description
Howdy,
In reading through src/helpers/Html.js, I noticed that the Html component is receiving the store as an ownProp and referencing it directly in its render function. Would it be better to wrap Html in react-redux, and have the serialized store data get passed into Html as a prop? Or is there a good reason to not do that in this particular instance which I'm not seeing?
Thanks!
Contributor guide
Assessment
This issue has not been assessed yet.