erikras / erikras/react-redux-universal-hot-example

site title isn't included in config.app.head for react-helmet

Open
#1,108 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.1k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

In **src/containers/App.js**, `config.app.head` is passed as [``](https://github.com/erikras/react-redux-universal-hot-example/blob/2fd505775d587dac15feb0816d4025bfa645b4fa/src/containers/App/App.js#L66). However, [`app.title`](https://github.com/erikras/react-redux-universal-hot-example/blob/2fd505775d587dac15feb0816d4025bfa645b4fa/src/config.js#L18) is not included in `config.app.head`. So that when **Html.js** calls [`{head.title.toComponent()}`](https://github.com/erikras/react-redux-universal-hot-example/blob/2fd505775d587dac15feb0816d4025bfa645b4fa/src/helpers/Html.js#L31), the title info is not showed.
Should we copy `config.app.title` to `config.app.head.title` in **src/config.js**?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.