erikras / erikras/react-redux-universal-hot-example

Server side render error handling broken

Open
#1,086 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.1k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

As I understand it, `react-transform-catch-errors` should catch any unhandled exceptions thrown on `render`, log the exception to console and render default (`redbox-react`) or custom error page.

I suspect the following change broke this logic (`react-transform-catch-errors v1.0.1+`):
https://github.com/gaearon/react-transform-catch-errors/commit/92057fd09a2def1b3e21495f2d32a47a56aac03e

Now the behavior is as follows: for server-side rendering exception is re-thrown via `setTimeout`, which basically means an uncatchable exception is thrown asynchronously and either breaks the response or hangs the request; for client-side it works because `setTimeout` effectively postpones re-throwing the exception until the error page is rendered.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.