erigontech / erigontech/silkworm

snapshots: avoid duplicated code in EliasFano list implementation

Open
#2,759 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
318
Forks
84
PR merge metrics
No merged PRs in 30d

Description

In #2753 our `EliasFanoList32` implementation has been splitted into 2 different classes for performance reasons:

- [`EliasFanoList32`](https://github.com/erigontech/silkworm/blob/master/silkworm/db/datastore/snapshots/elias_fano/elias_fano_list.hpp#L59)
- [`EliasFanoList32Builder`](https://github.com/erigontech/silkworm/blob/master/silkworm/db/datastore/snapshots/elias_fano/elias_fano_list.hpp#L129)

but some duplication exists between them, which we should strive to avoid.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.