erigontech / erigontech/silkworm

Polling downloading_queue in PoSSync::download_blocks

Open
#1,434 0 comments 0 reactions 0 assignees View on GitHub
pos sync
Dominant language
C++
Stars
318
Forks
84
PR merge metrics
No merged PRs in 30d

Description

There's a loop here: https://github.com/torquem-ch/silkworm/blob/60106e17de8eb034d251fa16c29725a2b11fe4ec/silkworm/sync/sync_pos.cpp#L85

That polls downloading_queue every 100ms.

We could avoid polling if the ThreadSafeQueue is replaced with a Channel.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.