erigontech / erigontech/erigon

do we need 1 GB TblCodeCache in MDBX vs just a 512MB LRU in-mem?

Open
#23,682 0 comments 0 reactions 1 assignee Claimed by @AskAlexSharov View on GitHub
performance
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 16h
Merged PRs (30d)
465

Description

follow up to: https://github.com/erigontech/erigon/pull/23666#issuecomment-5478612807

Not sure if we need a 1 GB MDBX table, a 512 mb LRU for code is likely enough.

Of course this needs metrics from mainnet to be sure. But this has somehow slipped into main without any proof of metrics/necessity (at least I don't remember seeing clear metrics supporting this move).

Main point is just to confirm if this is necessary and remove/disable if not.

EDIT: also an A/B run on latest benchmarkoor spec (based on gd8 on main) would be a good input

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.