erigontech / erigontech/erigon

execution/execmodule: audit published-SD readers (Events.LatestSD, bg-commit) for shared-cache coherence

Open
#22,214 1 comment 0 reactions 1 assignee Claimed by @yperbasis View on GitHub
tech debt reduction
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 16h
Merged PRs (30d)
455

Description

#22198 detached the SDs that create their *own* read snapshot outside the exec-module semaphore (payload builds, RPC-side `NewSharedDomains` sites) from the shared commitment BranchCache. A different reader class remains unaudited: goroutines reading *through the published canonical SD* while head progresses — `Events.LatestSD` consumers and the bg-commit configs. Their reads run without the semaphore, and read-fills they trigger (BranchCache, and the account/storage StateCache) land in shared caches from positions that may not be synchronized with the FCU flush/refresh cycle.

Audit whether those read-fills can land stale under the last-Put-wins semantics (the #22152 mechanism), and guard or detach as needed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.