erigontech / erigontech/erigon

`t8ntool/transition.go:418` `unusedwrite` linter fix

Open
#17,942 1 comment 0 reactions 1 assignee Claimed by @mh0lt View on GitHub
tech debt reduction
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 16h
Merged PRs (30d)
455

Description

We creating struct `commonTx` and then don't use it. Seems like refactoring bug from https://github.com/erigontech/erigon/pull/15413 :
```
we assign fields and then don't use them:

commonTx.V.SetFromBig(txJson.V.ToInt())
commonTx.R.SetFromBig(txJson.R.ToInt())
commonTx.S.SetFromBig(txJson.S.ToInt())
```

```
cmd/evm/internal/t8ntool/transition.go:418:8: unusedwrite: unused write to field Nonce (govet)
Nonce: uint64(txJson.Nonce),
^
cmd/evm/internal/t8ntool/transition.go:419:5: unusedwrite: unused write to field To (govet)
To: txJson.To,
^
cmd/evm/internal/t8ntool/transition.go:420:8: unusedwrite: unused write to field Value (govet)
Value: value,
^
cmd/evm/internal/t8ntool/transition.go:421:11: unusedwrite: unused write to field GasLimit (govet)
GasLimit: uint64(txJson.Gas),
^
cmd/evm/internal/t8ntool/transition.go:422:7: unusedwrite: unused write to field Data (govet)
Data: txJson.Input,
^
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.